bpo-45635: refactor print_exception() into smaller functions #29981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eback and print_exception_message out of print_exception
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
erlend-aasland
approved these changes
Dec 8, 2021
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit f06843b 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Member
Author
|
The failed testruns are failing on other branches as well, we have refleaks tests passing. So I'm merging. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step in the error handling tidy-up. I'm breaking it up because otherwise it's too much to review.
This PR breaks up print_exception by extracting parts of it to separate functions. Error handling in the new functions follow the standardized format, but print_exception itself not yet.
https://bugs.python.org/issue45635