bpo-45635: continue refactor of print_exception() to standardize error handling #29996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons to standardize error handling
Contributor
erlend-aasland
left a comment
There was a problem hiding this comment.
Nice! I left some comments :)
Python/pythonrun.c
Outdated
Comment on lines
1086
to
1088
| _Py_static_string(PyId_newline, "\n"); | ||
| PyObject *lines = PyUnicode_Split( | ||
| note, _PyUnicode_FromId(&PyId_newline), -1); |
Contributor
There was a problem hiding this comment.
Completely OT:
- Silly question: Why do we not use
PyUnicode_InternFromStringinstead of_Py_static_string+_PyUnicode_FromIdhere? - If
_PyUnicode_FromIdfails,PyUnicode_Splitwill default to use whitespace as separator. Is that ok? IMO, we should check that the separator object is notNULLbefore proceeding toPyUnicode_Split.
Member
Author
There was a problem hiding this comment.
Because I don't know what I'm doing :) (I added this recently, I'll change it).
Member
Author
There was a problem hiding this comment.
Actually why not PyUnicode_Splitlines?
Contributor
There was a problem hiding this comment.
Actually why not PyUnicode_Splitlines?
Oh, that's nice :)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45635