Remove new line in pickle error message#31782
Remove new line in pickle error message#31782iritkatriel merged 6 commits intopython:mainfrom harshil21:patch-1
Conversation
|
Hi, is this change going to be implemented? If not, I'll just close. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
I think it's failing because there isn't an issue for this PR. Maybe I should delete the NEWS.d entry then? |
nanjekyejoannah
left a comment
There was a problem hiding this comment.
Yes, remove the news entry
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
@serhiy-storchaka - as someone who's been looking at pickle issue recently, do you see any problem with this change? Does it need a news entry? |
serhiy-storchaka
left a comment
There was a problem hiding this comment.
It is a very old code. It was added in fdde96c.
I do not know reasons of adding a newline at the first place, but the change LGTM.
Removes the new line in the error message. Encountered this while testing something and found it a little weird that there would be a new line character when the error message is short anyway.