Skip to content

bpo-47038: Rewrite asyncio.wait_for test to use IsolatedAsyncioTestCase #31942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asvetlov merged 2 commits into from
Mar 16, 2022
Merged

bpo-47038: Rewrite asyncio.wait_for test to use IsolatedAsyncioTestCase #31942

asvetlov merged 2 commits into from
Mar 16, 2022

Conversation

@asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Mar 16, 2022 •
edited by bedevere-bot
Loading

@asvetlov asvetlov requested a review from 1st1 as a code owner March 16, 2022 19:23
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Mar 16, 2022
@asvetlov asvetlov merged commit dd0082c into main Mar 16, 2022
@asvetlov asvetlov deleted the asyncio-wait_for-tests branch March 16, 2022 19:49
@miss-islington
Copy link
Contributor

miss-islington commented Mar 16, 2022

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 16, 2022
@asvetlov @miss-islington
bpo-47038: Rewrite asyncio.wait_for test to use IsolatedAsyncioTestCa…
050bfad 
…se (pythonGH-31942)

(cherry picked from commit dd0082c)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Mar 16, 2022

Sorry, @asvetlov, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker dd0082c627713634c7fd88ad33d18b5cc9f4a7b8 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 16, 2022
@bedevere-bot
Copy link

bedevere-bot commented Mar 16, 2022

GH-31943 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

bedevere-bot commented Mar 16, 2022

GH-31944 is a backport of this pull request to the 3.9 branch.

asvetlov added a commit to asvetlov/cpython that referenced this pull request Mar 16, 2022
@asvetlov
[3.9] bpo-47038: Rewrite asyncio.wait_for test to use IsolatedAsyncio…
9cfc585 
…TestCase (pythonGH-31942).

(cherry picked from commit dd0082c)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
asvetlov added a commit that referenced this pull request Mar 16, 2022
@miss-islington @asvetlov
bpo-47038: Rewrite asyncio.wait_for test to use IsolatedAsyncioTestCa…
4186dd6 
…se (GH-31942) (GH-31943)

(cherry picked from commit dd0082c)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
asvetlov added a commit that referenced this pull request Mar 16, 2022
@asvetlov
[3.9] bpo-47038: Rewrite asyncio.wait_for test to use IsolatedAsyncio…
3244659 
…TestCase (GH-31942). (GH-31944)

(cherry picked from commit dd0082c)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@asvetlov @hello-adam
[3.9] bpo-47038: Rewrite asyncio.wait_for test to use IsolatedAsyncio…
b96a168 
…TestCase (pythonGH-31942). (pythonGH-31944)

(cherry picked from commit dd0082c)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees

@asvetlov asvetlov

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asvetlov @miss-islington @bedevere-bot @the-knights-who-say-ni