bpo-32318: Don't call 'globals()' in socket.accept() #4857
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
asvetlov
reviewed
Dec 14, 2017
| # accept4, so the returned socket is always blocking. | ||
| type = self.type & ~globals().get("SOCK_NONBLOCK", 0) | ||
| type = self.type | ||
| if _SOCK_NONBLOCK: |
Contributor
There was a problem hiding this comment.
Either _SOCK_NONBLOCK should be None if not present in socket -- then if _SOCK_NONBLOCK is not None: will be very fast check.
Or drop if: type & ~0 works pretty well
Member
There was a problem hiding this comment.
I agree with Andrew, I don't think that the if is needed.
Contributor
|
Should we close the issue? |
Member
Author
|
Yes, closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32318