bpo-32972: Add coroutine support to unittest #5938
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
4bb4739 to
669cec8
Compare
1st1
left a comment
There was a problem hiding this comment.
This needs more discussion in https://bugs.python.org/issue32972
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Signed-off-by: John Andersen <john.s.andersen@intel.com>
| def runMethod(cls, meth): | ||
| """Executes a function or coroutine function using the | ||
| coroutineRunner.""" | ||
| if inspect.iscoroutinefunction(meth): |
There was a problem hiding this comment.
This does not work if the method is decorated with @unittest.mock.patch.
|
@pdxjohnny Sorry that the discussion about this issue has languished, especially since the submitting of an alternate PR. However, I see your PR was created against the 3.6 branch; for enhancements, we require that PRs be against the "master" branch. So I'm going to close this PR and you can decide how you want to proceed, either submitting an updated PR against "master" or perhaps commenting on the other open PR. In any case, thanks for getting the discussion started and submitting this PR! |
|
I'm glad there has been discussion about it. Thank you!
…On Wed, Jun 6, 2018, 6:10 PM Ned Deily ***@***.***> wrote:
Closed #5938 <#5938>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5938 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFrL4UCjapm1cNVtW2kOjgRAH9AaJ8biks5t6H2ggaJpZM4SXJWo>
.
|
https://bugs.python.org/issue32972