Skip to content

bpo-32992: Unittest: Automatically run coroutines in a loop. #6005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PetterS wants to merge 1 commit into from
Closed

bpo-32992: Unittest: Automatically run coroutines in a loop. #6005

PetterS wants to merge 1 commit into from

Conversation

@PetterS
Copy link
Contributor

@PetterS PetterS commented Mar 6, 2018 •
edited by bedevere-bot
Loading

If test methods, setUp, or tearDown are coroutine functions, they will be
executed in the default loop.

https://bugs.python.org/issue32992

@PetterS
bpo-32992: Unittest: Automatically run coroutines in a loop.
4d7e183 
If test methods, setUp, or tearDown are coroutine functions, they will be
executed in the default loop.
1st1
1st1 requested changes Mar 6, 2018
View reviewed changes
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments in the issue. Let's first discuss it there.

@bedevere-bot
Copy link

bedevere-bot commented Mar 6, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@1st1
Copy link
Member

1st1 commented Mar 6, 2018

Closing the PR as its parent issue is a duplicate of another issue which already has an active PR.

@1st1 1st1 closed this Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 requested changes

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PetterS @bedevere-bot @1st1 @the-knights-who-say-ni