Skip to content

bpo-20104: Change the file_actions parameter of os.posix_spawn(). #6725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 2 commits into from
Sep 8, 2018
Merged

bpo-20104: Change the file_actions parameter of os.posix_spawn(). #6725

serhiy-storchaka merged 2 commits into from
Sep 8, 2018

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 8, 2018 •
edited by bedevere-bot
Loading

  • Make its default value an empty tuple instead of None.
  • Make it a keyword-only parameter.

https://bugs.python.org/issue20104

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label May 8, 2018
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jul 24, 2018
Merged
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jul 26, 2018
Merged
pablogsal
pablogsal approved these changes Jul 27, 2018
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Do you want to wait until #6693 is merged to land this or you prefer to do it before?

@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Jul 29, 2018 •
edited
Loading

It doesn't matter what PR will be merged first. But I want to wait for a review from any of other involved core devs: @benjaminp or @gpshead.

@serhiy-storchaka
bpo-20104: Change the file_actions parameter of os.posix_spawn().
9639c06 
* Make its default value an empty tuple instead of None.
* Make it a keyword-only parameter.
@serhiy-storchaka
Remove a news entry.
0b4798e
@serhiy-storchaka serhiy-storchaka merged commit d700f97 into python:master Sep 8, 2018
@serhiy-storchaka serhiy-storchaka deleted the posix_spawn-file_actions branch September 8, 2018 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@gpshead gpshead Awaiting requested review from gpshead

@ned-deily ned-deily Awaiting requested review from ned-deily

Assignees

No one assigned

Labels

skip news type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @pablogsal @the-knights-who-say-ni @bedevere-bot