Skip to content

[3.7] bpo-33353: Fix test_asyncio on FreeBSD #7087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 2 commits into from
May 24, 2018
Merged

[3.7] bpo-33353: Fix test_asyncio on FreeBSD #7087

vstinner merged 2 commits into from
May 24, 2018

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented May 24, 2018 •
edited by bedevere-bot
Loading

vstinner added 2 commits May 24, 2018 02:56
@vstinner
bpo-33353: test_asyncio uses smaller sendfile data (#7083)
b997e17 
bpo-32622, bpo-33353: sendfile() tests of test_asyncio use socket
buffers of 1 kB "to test on relative small data sets". Send only
160 KiB rather 10 MB to make the test much faster.

Shrink also SendfileBase.DATA from 1600 KiB to 160 KiB.

On Linux, 3 test_sock_sendfile_mix_with_regular_send() runs now take
less than 1 second, instead of 18 seconds.

On FreeBSD, the 3 tests didn't hang, but took 3 minutes. Now
the 3 tests pass in less than 1 seconds.

(cherry picked from commit 2932755)
@vstinner
bpo-33353: test_asyncio set SO_SNDBUF after connect (GH-7086)
8874771 
bpo-32622, bpo-33353: On macOS, sock.connect() changes the
SO_SNDBUF value. Only set SO_SNDBUF and SO_RCVBUF buffer sizes
once a socket is connected or binded, not before.

(cherry picked from commit b97de3d)
@vstinner vstinner requested review from 1st1 and asvetlov as code owners May 24, 2018 00:58
@vstinner vstinner mentioned this pull request May 24, 2018
Closed
@vstinner vstinner merged commit fa24c1c into python:3.7 May 24, 2018
@vstinner vstinner deleted the test_asyncio37 branch May 24, 2018 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot