GH-98897: fix memory leak if math.dist raises exception#98898
Merged
rhettinger merged 6 commits intopython:mainfrom Nov 1, 2022
Merged
GH-98897: fix memory leak if math.dist raises exception#98898rhettinger merged 6 commits intopython:mainfrom
math.dist raises exception#98898rhettinger merged 6 commits intopython:mainfrom
Conversation
vstinner
reviewed
Oct 31, 2022
Member
vstinner
left a comment
There was a problem hiding this comment.
Can you please add a test to make sure that we don't reintroduce this memory leak later?
Contributor
Author
Added test. |
vstinner
reviewed
Oct 31, 2022
Misc/NEWS.d/next/Library/2022-10-31-12-34-03.gh-issue-98897.rgNn4x.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Victor Stinner <vstinner@python.org>
rhettinger
approved these changes
Nov 1, 2022
Contributor
|
Looks good. Thanks for the bug report and patch. |
Contributor
|
Thanks @kumaraditya303 for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 1, 2022
…onGH-98898) (cherry picked from commit ab57505) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
|
GH-98941 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 1, 2022
…onGH-98898) (cherry picked from commit ab57505) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
|
GH-98942 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Nov 1, 2022
(cherry picked from commit ab57505) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Nov 1, 2022
(cherry picked from commit ab57505) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
math.distraises exception #98897