[mypyc] Speed up native-to-native calls using await#19398
Merged
Conversation
jhance
approved these changes
Jul 8, 2025
JukkaL
added a commit
that referenced
this pull request
Jul 9, 2025
Call the generator helper method directly instead of calling `PyIter_Next` when calling a native generator from a native function. This way we can avoid raising StopIteration when the generator is exhausted. The approach is similar to what I used to speed up calls using await in #19398. Refer to that PR for a more detailed explanation. This helps mostly when a generator produces a small number of values, which is quite common. This PR improves the performance of this microbenchmark, which is a close to the ideal use case, by about 2.6x (now 5.7x faster than interpreted): ``` from typing import Iterator def foo(x: int) -> Iterator[int]: for a in range(x): yield a def bench(n: int) -> None: for i in range(n): for a in foo(1): pass from time import time bench(1000 * 1000) t0 = time() bench(50 * 1000 * 1000) print(time() - t0) ```
hauntsaninja
pushed a commit
that referenced
this pull request
Nov 23, 2025
This is another problem caused by #19398 and a missing part of #20254 cc @JukkaL @hauntsaninja there is a small chance this may be related to the problems with black.
p-sawicki
pushed a commit
to p-sawicki/mypy
that referenced
this pull request
Nov 25, 2025
This is another problem caused by python#19398 and a missing part of python#20254 cc @JukkaL @hauntsaninja there is a small chance this may be related to the problems with black.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling a native async function using
await, e.g.await foo(), avoid raisingStopIterationto pass the return value, since this is expensive. Instead, pass an extraPyObject **argument to the generator helper method and use that to return the return value. This is mostly helpful when there are many calls using await that don't block (e.g. there is a fast path that is usually taken that doesn't block). When awaiting from non-compiled code, the slow path is still taken.This builds on top of #19376.
This PR makes this microbenchmark about 3x faster, which is about the ideal scenario for this optimization: