Fix overload diagnostic when vararg and varkwarg can match#19614
Merged
ilevkivskyi merged 1 commit intopython:masterfrom Aug 8, 2025
Merged
Fix overload diagnostic when vararg and varkwarg can match#19614ilevkivskyi merged 1 commit intopython:masterfrom
ilevkivskyi merged 1 commit intopython:masterfrom
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: kornia (https://github.com/kornia/kornia)
+ kornia/augmentation/container/augment.py:300: error: Unused "type: ignore" comment [unused-ignore]
+ kornia/augmentation/container/augment.py:427: error: Unused "type: ignore" comment [unused-ignore]
|
Collaborator
Author
|
mypy_primer is correct but only because we don't check argument names on override |
sterliakov
approved these changes
Aug 8, 2025
Collaborator
sterliakov
left a comment
There was a problem hiding this comment.
Makes sense, thank you!
hauntsaninja
added a commit
that referenced
this pull request
Aug 9, 2025
#19614 got merged faster than I expected :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19612