Conversation
|
I'll keep this PR open for a while, in case somebody else wants to review the changes, but we will merge this once this is needed to unblock the 1.19 release. |
ilevkivskyi
left a comment
There was a problem hiding this comment.
LG, added some optional comments.
CHANGELOG.md
Outdated
There was a problem hiding this comment.
I guess it should be floats, not flats.
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Not sure about the comma here, AI says no comma is needed for cumulative adjectives (whatever it means).
| - Support deleting attributes in `__setattr__` wrapper (Piotr Sawicki, PR [19997](https://github.com/python/mypy/pull/19997)) | ||
|
|
||
| Mypyc now has partial support for `__getattr__`, `__setattr__` and | ||
| `__delattr__` methods in native classes. |
There was a problem hiding this comment.
Assuming we are going forward with #20302 instead of a revert, we should probably also mention __new__().
There was a problem hiding this comment.
Yeah, I'll add it before merging depending on the final outcome.
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Maybe also remind how to enable the FF cache.
The first draft was added in #20296.
The first draft was added in #20296.