Skip to content

Conversation

@hauntsaninja
Copy link
Collaborator

No description provided.

hauntsaninja added 2 commits February 4, 2020 16:04
Seems it was rendered useless in bpo-28009
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed the weird unused getters argument as bpo-39559.

@srittau srittau merged commit 6956448 into python:master Feb 5, 2020
@hauntsaninja hauntsaninja deleted the uuid branch February 5, 2020 18:21
def __cmp__(self, other: Any) -> _Int: ...

def getnode() -> int: ...
def getnode(*, getters: None = ...) -> int: ... # getters is undocumented (and unused)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it got removed from CPython master, maybe we should also just omit it from typeshed? There's no reason for anyone to actually use the argument.

hauntsaninja pushed a commit to hauntsaninja/typeshed that referenced this pull request May 16, 2020
Closing the long loop started in python#3715
hauntsaninja pushed a commit to hauntsaninja/typeshed that referenced this pull request May 16, 2020
Closing the long loop started in python#3715
JelleZijlstra pushed a commit that referenced this pull request May 16, 2020
Closing the long loop started in #3715

Co-authored-by: hauntsaninja <>
JelleZijlstra added a commit that referenced this pull request May 17, 2020
Closing the long loop started in #3715

Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com>
vishalkuo pushed a commit to vishalkuo/typeshed that referenced this pull request Jun 26, 2020
Closing the long loop started in python#3715

Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants