Skip to content

map logical to 1 or 0 independent of compiler in mc01td#103

Merged
roryyorke merged 3 commits intopython-control:masterfrom
bnavigator:fortrantruefalse
Apr 13, 2020
Merged

map logical to 1 or 0 independent of compiler in mc01td#103
roryyorke merged 3 commits intopython-control:masterfrom
bnavigator:fortrantruefalse

Conversation

@bnavigator
Copy link
Collaborator

@bnavigator bnavigator commented Apr 13, 2020

fixes #102

Maybe there is a smaller version by putting the .TRUE. / .FALSE. inline into the wrapper or subroutine block.

@bnavigator bnavigator mentioned this pull request Apr 13, 2020
Closed
roryyorke
roryyorke approved these changes Apr 13, 2020
View reviewed changes
Copy link
Collaborator

@roryyorke roryyorke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passes with my the build script I posted in #102, thanks.

It would have been easier to review with a targeted change (no reordering, etc.).

@roryyorke roryyorke merged commit 3a24b5a into python-control:master Apr 13, 2020
@roryyorke roryyorke mentioned this pull request Apr 13, 2020
Closed
@bnavigator
Copy link
Collaborator Author

bnavigator commented Apr 13, 2020

It would have been easier to review with a targeted change (no reordering, etc.).

Sorry for the confusion. The move within math.py and the subsequent numpydoc change are separate commits, so reviewing the pure change would have been possible by looking at the math.py section of 25da4dd directly

@bnavigator bnavigator deleted the fortrantruefalse branch December 31, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roryyorke roryyorke roryyorke approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_mc01td_D failure on Windows

2 participants

@bnavigator @roryyorke