Merged
Conversation
Merged
roryyorke
approved these changes
Jan 8, 2021
Collaborator
roryyorke
left a comment
There was a problem hiding this comment.
Thanks @bnavigator , looks good.
|
|
||
| message(STATUS "NumPy: ${NumPy_INCLUDE_DIR}") | ||
| message(STATUS "NumPy included from: ${NumPy_INCLUDE_DIR}") | ||
| message(STATUS "F2PY included from: ${F2PY_INCLUDE_DIR}") |
Collaborator
There was a problem hiding this comment.
F2PY_INCLUDE_DIR isn't documented as being set (see https://github.com/scikit-build/scikit-build/blob/c0741f9a1de9dd97e0a1e6f0b3b02fcd76221418/skbuild/resources/cmake/FindF2PY.cmake). This is possibly just an oversight in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that some of the code in setup.py and the CMake files is no longer needed. Not even for Windows. (#140 is not ready yet, but it builds on this one and I already had successful Windows builds which also passed the unit tests.)
Dropped Python 2 and Python 3.5 support