improve forced_response and its documentation#588
Merged
bnavigator merged 12 commits intopython-control:masterfrom Apr 2, 2021
Merged
improve forced_response and its documentation#588bnavigator merged 12 commits intopython-control:masterfrom
bnavigator merged 12 commits intopython-control:masterfrom
Conversation
Contributor
Author
|
Strange that the markov test fails here too. https://github.com/python-control/python-control/pull/588/checks?check_run_id=2188093854#step:5:212 A rerun succeeded. Wonder what triggered the length mismatch of Y and U. |
murrayrm
reviewed
Mar 25, 2021
a09e98c to
66b381f
Compare
Contributor
Author
|
Even without the modifications of this PR, Fixed with a6ea296 TODO: cover the new lines. They were only triggered by the testMarkovResults test depending on the random seed. |
a6ea296 to
77c3b40
Compare
bnavigator
added a commit
to bnavigator/python-control
that referenced
this pull request
Mar 31, 2021
bnavigator
added a commit
that referenced
this pull request
Mar 31, 2021
xfail testmarkovResults until #588 is merged
sawyerbfuller
approved these changes
Apr 1, 2021
Contributor
sawyerbfuller
left a comment
There was a problem hiding this comment.
Looks good. Seems reasonable to allow a nonzero start time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
return_xas revealed by control.forced_response argument T #586.Remove redundant kwarg defaults. They are in the call signuature.Numpydoc compliant default indication