Signed-off-by: whiplash01 <amirhasandex@gmail.com>#70
Signed-off-by: whiplash01 <amirhasandex@gmail.com>#70whiplash01 wants to merge 1 commit intopython-control:masterfrom
Conversation
Updated the gm and wg values Faulty values were failing the tests, This commit fixes it.
|
I don't think the patch is right; testCombi01 passes fine on master 49045ca [1], and that's on Python 2.7, 3.3, and 3.4. The numbers you've used look odd; a GM of 1e-15 at a frequency of 1e-9 seems implausible. It might be there's a bug lurking in the margin code. What OS, Python, Numpy, and slycot version did you use to test this? (Can't recall offhand if slycot code is used in the margin calcs---probably not). [1] https://travis-ci.org/python-control/python-control/builds/90145794 |
|
@roryyorke Thanks for responding. When I was installing python-control, I was having this error on Gm and Wg values which on terminal appeared as this should be this. I replaced the values and all the tests ran fine. It worked. I am not a control engineering expert, so I can't determine whether the values I have selected are even in the ballpark. Therefore, I concluded it was a bug. OS - Ubuntu 14.04 LTS Some help would be appreciated. |
|
unfortunately I'll be offline for about a week. I am using Ubuntu 14.04 and Python 2.7 as well. I can only give general advice now: use virtualenv, try miniconda, and look
|
|
Thanks, I'll check it. |
Updated the gm and wg values
Faulty values were failing the tests, This commit fixes it.