Relax comparison of floats in tests#818
Merged
bnavigator merged 3 commits intopython-control:mainfrom Dec 21, 2022
Merged
Conversation
Member
|
Odd that we are still seeing the FRD error and that this only happens in the slycot from source version. |
Member
|
I'm seeing some problems in my own copy of this branch. It looks like using |
Member
|
It looks like the problem in the FRD tests had to do with using |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to fix python-control/Slycot#187 in python-control/Slycot#188, I ran into precision related errors of the control test suite. Seems like the new NumPy moves around some libraries affecting the floats.
There are more errors related to the frequency vector calculation of FRDs, which need to be investigated.