Fix nyquist plotting from FrequencyResponseData#996
Merged
murrayrm merged 3 commits intopython-control:mainfrom Jun 8, 2024
Merged
Fix nyquist plotting from FrequencyResponseData#996murrayrm merged 3 commits intopython-control:mainfrom
murrayrm merged 3 commits intopython-control:mainfrom
Conversation
Member
|
This is a good fix, but I think we could add a bit better support if there are multiple FRD systems with different frequencies and not explicit frequency list given. For example, try this: It seems to me that the last case should work OK and just plot each system independently, without needing a common frequency range (as it does for Bode plots). |
This was referenced Jun 13, 2024
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue #992, by adding a check for FrequencyResponseData during plotting of a nyquist plot and setting omega if not yet set correctly