Changed User.chat_id to User.id in docstrings of User.send_* methods in user.py#1081
Merged
tsnoam merged 4 commits intopython-telegram-bot:masterfrom Apr 25, 2018
jonowo:master
Merged
Changed User.chat_id to User.id in docstrings of User.send_* methods in user.py#1081tsnoam merged 4 commits intopython-telegram-bot:masterfrom jonowo:master
tsnoam merged 4 commits intopython-telegram-bot:masterfrom
jonowo:master
Conversation
Users do not have chat ids.
Corrected docstrings.
Chat.chat_id --> Chat.id
tsnoam
approved these changes
Apr 25, 2018
Member
|
@Tr-Jono |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the
User.send_*methods' docstrings show that they are shortcuts forbot.send_*(User.chat_id, *args, **kwargs)methods inuser.py, I replacedUser.chat_idwithUser.idin the docstrings in these methods, becauseUserdoes not have the attributechat_idand I believe it has been confused as the attributeid.The amended
User.send_*methods include:User.send_audioUser.send_documentUser.send_messageUser.send_photoUser.send_stickerUser.send_videoUser.send_video_noteUser.send_voiceEdit: Found similar mistakes in
Chat.send_*methods inChat.pyso I added them to this PR.