Skip to content

Add urllib3 fix for socks5h support#1085

Merged
tsnoam merged 1 commit intomasterfrom
urllib3_socks5h
Apr 25, 2018
Merged

Add urllib3 fix for socks5h support#1085
tsnoam merged 1 commit intomasterfrom
urllib3_socks5h

Conversation

@tsnoam
Copy link
Member

@tsnoam tsnoam commented Apr 25, 2018

FIxes #1077
Changes semantics of socks proxy behaviour.
Until now - socks5:// was actually socs5h:// and we didn't really have socks5://

Copy link
Member

@jh0ker jh0ker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsnoam tsnoam merged commit 1ec1234 into master Apr 25, 2018
@tsnoam tsnoam deleted the urllib3_socks5h branch April 25, 2018 18:23
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Socks proxy error

2 participants