Fix ProcessLookupError if process finishes before we kill it#1126
Merged
tsnoam merged 1 commit intopython-telegram-bot:masterfrom Jun 1, 2018
socram8888:proclookuperr
Merged
Fix ProcessLookupError if process finishes before we kill it#1126tsnoam merged 1 commit intopython-telegram-bot:masterfrom socram8888:proclookuperr
tsnoam merged 1 commit intopython-telegram-bot:masterfrom
socram8888:proclookuperr
Conversation
tsnoam
approved these changes
May 29, 2018
Member
tsnoam
left a comment
There was a problem hiding this comment.
LGTM
I restarted the unitests, though it doesn't look like the failures are related to this change.
Also, you may add yourself to AUTHORS.rst if you'd like.
Member
|
@socram8888 |
Contributor
Author
|
You're welcome. I'll look into the other PR as soon as I get some more free time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1125