Add vCard field to Contact and related#1166
Closed
spontanurlaub wants to merge 0 commit intopython-telegram-bot:bot-api-4.0from
spontanurlaub:master
Closed
Add vCard field to Contact and related#1166spontanurlaub wants to merge 0 commit intopython-telegram-bot:bot-api-4.0from spontanurlaub:master
spontanurlaub wants to merge 0 commit intopython-telegram-bot:bot-api-4.0from
spontanurlaub:master
Conversation
Eldinnie
reviewed
Jul 26, 2018
telegram/bot.py
Outdated
| phone_number=None, | ||
| first_name=None, | ||
| last_name=None, | ||
| vcard=None, |
Member
There was a problem hiding this comment.
Please move the argument to the last in the method signature (just before **kwargs).
| phone_number, | ||
| first_name, | ||
| last_name=None, | ||
| vcard=None, |
telegram/bot.py
Outdated
| phone_number = contact.phone_number | ||
| first_name = contact.first_name | ||
| last_name = contact.last_name | ||
| vcard = contact.vcard |
Member
There was a problem hiding this comment.
Since vcard is optional I would prefer it if vcard was only added here if it was available in the original contact.
tests/test_contact.py
Outdated
| first = data['first_name'] == contact.first_name | ||
| last = data['last_name'] == contact.last_name | ||
| return phone and first and last | ||
| vcard = data['vcard'] == contact.vcard |
Member
There was a problem hiding this comment.
I think this should split int two seperate tests. One with vcard, one without. Also see comment above
Member
|
Left a review. Please adress those issues. |
Eldinnie
requested changes
Jul 26, 2018
Member
Eldinnie
left a comment
There was a problem hiding this comment.
Some small changes requested
jsmnbom
added a commit
that referenced
this pull request
Aug 29, 2018
Telegram Passport (#1174): - Add full support for telegram passport. - New types: PassportData, PassportFile, EncryptedPassportElement, EncryptedCredentials, PassportElementError, PassportElementErrorDataField, PassportElementErrorFrontSide, PassportElementErrorReverseSide, PassportElementErrorSelfie, PassportElementErrorFile and PassportElementErrorFiles. - New bot method: set_passport_data_errors - New filter: Filters.passport_data - Field passport_data field on Message - PassportData is automagically decrypted when you specify your private key when creating Updater or Bot. - PassportFiles is also automagically decrypted as you download/retrieve them. - See new passportbot.py example for details on how to use, or go to our telegram passport wiki page for more info - NOTE: Passport decryption requires new dependency `cryptography`. Inputfile rework (#1184): - Change how Inputfile is handled internally - This allows support for specifying the thumbnails of photos and videos using the thumb= argument in the different send_ methods. - Also allows Bot.send_media_group to actually finally send more than one media. - Add thumb to Audio, Video and Videonote - Add Bot.edit_message_media together with InputMediaAnimation, InputMediaAudio, and inputMediaDocument. Other Bot API 4.0 changes: - Add forusquare_type to Venue, InlineQueryResultVenue, InputVenueMessageContent, and Bot.send_venue. (#1170) - Add vCard support by adding vcard field to Contact, InlineQueryResultContact, InputContactMessageContent, and Bot.send_contact. (#1166) - Support new message entities: CASHTAG and PHONE_NUMBER. (#1179) - Cashtag seems to be things like $USD and $GBP, but it seems telegram doesn't currently send them to bots. - Phone number also seems to have limited support for now - Add Bot.send_animation, add width, height, and duration to Animation, and add Filters.animation. (#1172) Co-authored-by: Jasmin Bom <jsmnbom@gmail.com> Co-authored-by: code1mountain <32801117+code1mountain@users.noreply.github.com> Co-authored-by: Eldinnie <pieter.schutz+github@gmail.com> Co-authored-by: mathefreak1 <mathefreak@hi2.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the vCard field to Contact, InlineQueryResultContact, InputContactMessageContent and bot.send_contact as mentioned in Issue #1165
Also added the corresponding tests