Adjust persistence on exit behaviour#1312
Merged
jsmnbom merged 4 commits intopython-telegram-bot:masterfrom Feb 13, 2019
Bibo-Joshi:persistence-on-exit
Merged
Adjust persistence on exit behaviour#1312jsmnbom merged 4 commits intopython-telegram-bot:masterfrom Bibo-Joshi:persistence-on-exit
jsmnbom merged 4 commits intopython-telegram-bot:masterfrom
Bibo-Joshi:persistence-on-exit
Conversation
Member
Author
|
If #1325 is merged, the new |
Member
|
As per #1301 I'd love to have this in v12, but I'm not comfortable enough the persistence component yet, so I'll hold off till the author can review or I get more time. |
Member
|
Right, good addition! |
Eldinnie
approved these changes
Feb 13, 2019
Member
|
I pushed two commits to fix a docstring and add tests. If CI approves it;s good to go |
Member
|
CI fail unrelated, will fix on master |
This was referenced Aug 4, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
user_dataandchat_datamight be changed between updates (e.g. when storing information from background processes that need to be visible to the user on request), they should be updated before callingflush()on shutdown of the bot. I therefore added the methodupdate_persistence()to theDispatcherclass, that is called from theUpdaterbefore flushing on shutdown.Also, since it will be called on shutdown,
flush()should always flush. I therefore edited the method inPicklePersistenceto be independent ofon_flush.