FIXED: ConversationHandler warnings were logged to root logger#1315
Closed
Tom-Brouwer wants to merge 1 commit intopython-telegram-bot:masterfrom
Tom-Brouwer:fix/conversationhandler_logging20182012
Closed
FIXED: ConversationHandler warnings were logged to root logger#1315Tom-Brouwer wants to merge 1 commit intopython-telegram-bot:masterfrom Tom-Brouwer:fix/conversationhandler_logging20182012
Tom-Brouwer wants to merge 1 commit intopython-telegram-bot:masterfrom
Tom-Brouwer:fix/conversationhandler_logging20182012
Conversation
Member
|
I wonder if we shouldn't really be using
|
Member
|
I think |
Member
|
This has been superseeded #1343. Thanks a lot for the PR @Tom-Brouwer, your commit also exists in that PR, we must wanted to make a couple of commits on top. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several warnings for the conversationhandler were logged to the root logger (logging.logger), instead of the module level logger (self.logger)