Skip to content

Add WAITING state and behavior#1344

Merged
Eldinnie merged 2 commits intoV12from
Fix_1250
Feb 14, 2019
Merged

Add WAITING state and behavior#1344
Eldinnie merged 2 commits intoV12from
Fix_1250

Conversation

@Eldinnie
Copy link
Member

* Remove `run_async_timeout` and `timed_out_behavior` arguments
* replace with `WAITING` constant and behavior from states
* never wait for promise to resolve (will hang up entire update queue
* see #1250 for discussion
Pytest 4.2.1 has a weird bug on top level collect in 4.2.1 Fixing version to 4.2.0
@jsmnbom jsmnbom added this to the V12 milestone Feb 14, 2019
@Eldinnie Eldinnie merged commit cd7c642 into V12 Feb 14, 2019
@Eldinnie Eldinnie deleted the Fix_1250 branch February 14, 2019 10:00
@Bibo-Joshi Bibo-Joshi mentioned this pull request Sep 13, 2019
@falkolab
Copy link

Hi @Eldinnie please pay attention. Docs still has mention about run_async_timeout

@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants