Conversation
|
Looks pretty good all around, got some comments though.
|
|
@jsmnbom I will address your notes later, want to see if this indeed fixes Travis' behavior |
|
I am looking forward for your improvements and will try out asap ... |
|
@Eldinnie any updates on this? Do you agree with my comments? I can implement them if you dont' have time ^ ^ |
|
Any updates about this PR? I have the same issue as #1332 ( ._.) |
|
As long as this PR is not accepted into Release 12 I have tricked around with something like this which is not beautiful but does the necessary change: |
This adds a prefix of `Bot:<id>:worker:` to the name of the worker threads. Fixes #1332
|
Renamed all threads and changed base. |
|
@jsmnbom care to take another look? |
|
This mostly looks good now, but i still don't think i can see my comment 3 adressed?
|
|
No you can't. |
jsmnbom
left a comment
There was a problem hiding this comment.
Alright, if that's not possible then, this looks good :)
This adds a prefix of
Bot:<id>:worker:to the name of the worker threads.Fixes #1332