API 4.4 changes#1464
Merged
tsnoam merged 22 commits intopython-telegram-bot:masterfrom Sep 6, 2019
Bibo-Joshi:api-4.4
Merged
Conversation
|
FYI: The 4.2 and 4.3 Changes are still not merged: #1418 |
added 5 commits
August 5, 2019 18:03
|
Pls remove the |
Member
Author
|
Ah, overlooked that one. Thanks for the heads up :) |
Conflicts: telegram/chatmember.py tests/test_bot.py
Closed
tsnoam
approved these changes
Sep 6, 2019
This reverts commit c4538e5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to incorporate API 4.4 changes.
Stuff I'm not sure I handled it correctly:
de_jsonmethods (ChatandChatPermission)all_members_are_administratorsinChatrestrict_chat_membersinBotMessageEntities: I adjustedMessage._parse_htmlandMessage._parse_markdownto allow for this. However, this only allows something like_bold *within* italic_and not*bold _overlapping* italic_. The announcement is not every clear, if that is also allowed …Did I miss anything?