Add instance methods to Animation and ChatPhoto#1489
Merged
tsnoam merged 7 commits intopython-telegram-bot:masterfrom Sep 13, 2019
zeshuaro:update-animation
Merged
Add instance methods to Animation and ChatPhoto#1489tsnoam merged 7 commits intopython-telegram-bot:masterfrom zeshuaro:update-animation
tsnoam merged 7 commits intopython-telegram-bot:masterfrom
zeshuaro:update-animation
Conversation
Bibo-Joshi
reviewed
Sep 6, 2019
Member
There was a problem hiding this comment.
Thanks for this PR, @zeshuaro! I think this is a good addition. A few notes:
- Please add
telegram.Animationto the doc string ofbot.get_file - The updated tests seem to be copy-pasted from
test_audio, so they should be fine. I'd still like to have one @python-telegram-bot/maintainers review them … - While you're at it, do you thinks you could add
get_small_fileandget_big_filetoChatPhoto?
AFAICS the failed tests are only due to test_official, but the test setup was updated to allow for that to fail. So if merge from master, we can see, if everthing passes :)
Contributor
Author
|
I've fixed the issues that you pointed out and added the new methods. |
Member
|
Yes, thanks! |
Bibo-Joshi
approved these changes
Sep 9, 2019
Member
|
@zeshuaro Thank you for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.