increase update_id by 1 to skip bad server response#1651
Closed
isjerryxiao wants to merge 2 commits intopython-telegram-bot:masterfrom
isjerryxiao:master
Closed
increase update_id by 1 to skip bad server response#1651isjerryxiao wants to merge 2 commits intopython-telegram-bot:masterfrom isjerryxiao:master
isjerryxiao wants to merge 2 commits intopython-telegram-bot:masterfrom
isjerryxiao:master
Conversation
Contributor
Author
|
However, 98e15ea is the main part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A possible fix for #1609.
We actually should not ignore unicode decode error or json decode error in order to make it work, my solution is to increase last_update_id by 1 until that bad update is skipped.
This may cause the bot to lose some of its updates, which is a little bit of a problem. However this is way better than looping and throwing exceptions endlessly.