4.6 API update by Poolitzer · Pull Request #1723 · python-telegram-bot/python-telegram-bot

Poolitzer · 2020-01-23T19:58:39Z

docs need to be built and checked. Tests should run through now.

When API 4.5 #1508 is merged to master, merge master and update Message._parse_* to handle the MessageEntities.language attribute correctly. Doesn't actually do anything yet, but we should still add it to Message.text_html and friends
Make test_official fail again (i.e. partly revert improve CI #1716)

closes #1722

Poolitzer · 2020-01-23T20:03:00Z

I am pretty sure I would need to add the new objects to the init file, didn't do it.

Poolitzer · 2020-01-23T20:07:05Z

Okay, all failed tests are unrelated, I think

telegram/messageentity.py

Poolitzer · 2020-01-24T01:54:51Z

telegram/keyboardbutton.py:docstring of telegram.KeyboardButton:41: WARNING: Unexpected indentation.

I can't get rid of that, but I don't think I have inserted that error :D

Bibo-Joshi · 2020-01-24T15:53:33Z

telegram/keyboardbutton.py:docstring of telegram.KeyboardButton:41: WARNING: Unexpected indentation.

I can't get rid of that, but I don't think I have inserted that error :D

Yes you did ;P Don't put whitespaces on begging of lines - linebreaks count as whitespace.

Bibo-Joshi

Thanks for the PR!
Apart from my nitpicking below we should add a test files for the new KeyboardButtonPollType and PollAnswer or integrate it into test_keyboardbutton.py and test_poll.py, respectively.

telegram/__init__.py

telegram/bot.py

telegram/keyboardbuttonpolltype.py

telegram/poll.py

Poolitzer · 2020-01-25T03:57:40Z

I added the missing filter as discussed in private. Do I have to add tests?

Bibo-Joshi · 2020-01-27T15:43:57Z

Telegram added a note to KeyboardButton about which versions support request_poll. Please add this one here as well. I'll try to review again shortly :)

Poolitzer · 2020-01-28T04:49:27Z

@Bibo-Joshi but I already did?

python-telegram-bot/telegram/keyboardbutton.py

Lines 53 to 54 in 7d25d19

    
                   :attr:`request_poll` option will only work in Telegram versions released after 23 January, 
        
                   2020. Older clients will receive unsupported message.

tests/test_filters.py

github-actions

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

Poolitzer · 2020-02-02T21:51:07Z

Missing: Tests and docs for new handlers.

Maybe improving pollbot docs.

telegram/bot.py

when trying to send a poll with correct option id 0 it was failing. Now None check is done so that even when 0 is passed it is assigned.

correct_option_id validated with None

Poolitzer · 2020-02-10T06:56:34Z

Id live to have you "helping" ;P

Also, reminder to myself, I need to include the poll filter in the example

Bibo-Joshi · 2020-02-10T07:17:33Z

Id live to have you "helping" ;P

Will try to. Probably will take a few days

Bibo-Joshi · 2020-02-15T14:29:18Z

Here you go :-*
Took the liberty to simplify the example a bit and restore the intended behaviour of Filters.poll

Poolitzer · 2020-02-15T23:06:36Z

Thank you very much :)

simonsmh · 2020-03-11T16:51:43Z

When will this pull request get merged?

Poolitzer · 2020-03-11T17:07:55Z

We dont like giving an ETA, sorry. That being said its on our list (obviously). Maintainers just need to find time in their life.

simonsmh · 2020-03-11T17:17:26Z

Actually I am using this branch for quite a long time and doesn't meet any problem so far. I'm just curious for why it doesn't get any update for nearly a month as I need some of the new feature to show my idea to others. Anyway thanks for your work.

examples/pollbot.py

First take on 4.6 support

9c8b803

Bibo-Joshi added the ⚙️ bot-api affected functionality: bot-api label Jan 23, 2020

Poolitzer added this to the 12.4.2 milestone Jan 23, 2020

Poolitzer changed the title ~~First take on 4.6 support~~ 4.6 ali update Jan 23, 2020

Poolitzer changed the title ~~4.6 ali update~~ 4.6 API update Jan 23, 2020

Bibo-Joshi reviewed Jan 23, 2020

View reviewed changes

telegram/messageentity.py Outdated Show resolved Hide resolved

improved docs

9e7274a

Bibo-Joshi mentioned this pull request Jan 24, 2020

Make (most) objects comparable #1724

Merged

4 tasks

Minor doc formattings

8d0fa03

Bibo-Joshi requested changes Jan 24, 2020

View reviewed changes

added poll and poll_answer to filters

d265ecc

added tests, fixed mentioned issues

0849835

Bibo-Joshi mentioned this pull request Jan 26, 2020

Add poll messages support to filters #1673

Merged

added poll_answer + poll filter tests

7d25d19

Bibo-Joshi reviewed Jan 28, 2020

View reviewed changes

tests/test_filters.py Outdated Show resolved Hide resolved

tests/test_filters.py Outdated Show resolved Hide resolved

python-telegram-bot deleted a comment from Poolitzer Jan 29, 2020

Bibo-Joshi and others added 3 commits January 31, 2020 17:09

Update docs according to official API docs

a929274

introducing pollhandler and pollanswerhandler

6239d9a

Merge remote-tracking branch 'upstream/4.6-update' into 4.6-update

5557e2a

github-actions bot reviewed Feb 2, 2020

View reviewed changes

Poolitzer added 2 commits February 2, 2020 21:39

First take on 4.6 support

bd1eafe

improved docs

4836de4

sharunkumar suggested changes Feb 8, 2020

View reviewed changes

telegram/bot.py Outdated Show resolved Hide resolved

sharunkumar and others added 3 commits February 8, 2020 22:56

correct_option_id validated with None

8f1f251

when trying to send a poll with correct option id 0 it was failing. Now None check is done so that even when 0 is passed it is assigned.

Merge pull request #1764 from sharunkumar/patch-1

a5e770f

correct_option_id validated with None

improving example

a36ffd2

Poolitzer and others added 7 commits February 10, 2020 20:56

improving code

517cc3d

adding poll filter example to the pollbot.py

92556df

Update Readme

f9883e3

simplify pollbot.py and add some comments

a275257

add tests for Poll(Answer)Handler

a2fa913

Merge branch 'master' into 4.6-update

4556f09

We just want Filters.poll, not Filters.update.poll

ded8788

Bibo-Joshi mentioned this pull request Mar 6, 2020

[FEATURE] Duplicate #1813

Closed

jay-babu reviewed Mar 28, 2020

View reviewed changes

examples/pollbot.py Show resolved Hide resolved

Bibo-Joshi added 4 commits March 28, 2020 14:38

Merge master

41d4da8

Merge branch 'master' into 4.6-update

413b518

Make test_official fail again

0dd5931

Handle ME.language in M._parse_*

472d981

This was referenced Mar 28, 2020

API 4.6 #1850

Closed

Prepare bumping version #1851

Closed

Bibo-Joshi merged commit 55e3ecf into master Mar 29, 2020

Bibo-Joshi mentioned this pull request Mar 29, 2020

Add missing docs for Poll(Answer)Handler #1853

Merged

Bibo-Joshi deleted the 4.6-update branch March 29, 2020 09:19

github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2020

Conversation

Poolitzer commented Jan 23, 2020 • edited by Bibo-Joshi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Poolitzer commented Jan 23, 2020

Uh oh!

Poolitzer commented Jan 23, 2020

Uh oh!

Uh oh!

Poolitzer commented Jan 24, 2020

Uh oh!

Bibo-Joshi commented Jan 24, 2020

Uh oh!

Bibo-Joshi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Poolitzer commented Jan 25, 2020

Uh oh!

Bibo-Joshi commented Jan 27, 2020

Uh oh!

Poolitzer commented Jan 28, 2020

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Poolitzer commented Feb 2, 2020

Uh oh!

Uh oh!

Poolitzer commented Feb 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bibo-Joshi commented Feb 10, 2020

Uh oh!

Bibo-Joshi commented Feb 15, 2020

Uh oh!

Poolitzer commented Feb 15, 2020

Uh oh!

simonsmh commented Mar 11, 2020

Uh oh!

Poolitzer commented Mar 11, 2020

Uh oh!

simonsmh commented Mar 11, 2020

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Poolitzer commented Jan 23, 2020 •

edited by Bibo-Joshi

Loading

Poolitzer commented Feb 10, 2020 •

edited

Loading