Make Filters.command only accept MessageEntity commands#1744
Merged
Conversation
Member
Author
|
Added changes as discussed in #1755 . Implementation is similar to the one of |
Member
Author
|
CI fail unrelated ( |
harshil21
added a commit
to tmslads/Shanispeakbot
that referenced
this pull request
Feb 11, 2020
Added support for nicknames. This will be used globally. In `/tell` Fixed the structure of user_data. Added missing escape character in one of the answers in `8ball.py`. You can now use `/8ball` anywhere in the message to trigger it, rather than just in the beginning of the message. Refer (#1744)[python-telegram-bot/python-telegram-bot#1744] Added conversation timeouts to both conversations. Group handler now filters both group and text messages. Might eliminate the need of checking if it is None or not. Now calculates your age based on DOB. General fixes Improved import statements (again)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
CommandHandleris only accepting commands marked by aMessageEntitysince v12.0.0 (#1114), I thought it fitting forFilters.commandto do the same.However, this is a breaking change, which is why I put this into the v13 Milestone.
Closes #1755