Remove NullHandlers to unsuppress lastResort loging handler#1913
Merged
Bibo-Joshi merged 1 commit intopython-telegram-bot:masterfrom May 3, 2020
Merged
Conversation
Member
|
Sounds good to me. |
Member
|
@Poolitzer Need to be carefully reviewed. |
Member
|
@tsnoam But in my opinion still a very important fix to have |
Contributor
Author
|
I'm reasonably sure NullHandlers were only needed to avoid "no handlers could be found for logger" error with py2, as lastResort handler was only added in py3.2. Since PTB no longer supports py2 it should be fine to remove them. |
Eldinnie
approved these changes
May 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the requirement to call
logging.basicConfig()to see errors raised in handlers.Users that already configure logging are unaffected by this change. Users that rely on python default logging configuration will now see warning+ level logs from PTB in stderr.
Suppressing default logging handler is not a good way control whether or not PTB logging is enabled, since users that actually do want to disable PTB logs might need to use basicConfig to configure something else. For this reason I removed all NullHandlers and not just the ones in dispatcher and updater.