Conversation
|
@Bibo-Joshi Last time I faced this error in the support groups I suggested checking the dimensions of it. Maybe try uploading said photo as document, if that works, that might be it? |
|
@Poolitzer Problem seems to be sending a photo via with open('tests/data/thumb.jpg', 'rb') as f:
bot.send_photo(chat_id, f)
Problem persists, if I swat |
Poolitzer
left a comment
There was a problem hiding this comment.
great PR, slight improvement
|
One thing: What about adding the emojis from Dice as constants? We normally do that. Right now we only have a list. |
Added that. Still kept the |
|
@Bibo-Joshi Sure, didnt complain about that ;P |
|
CI Fail: |
tsnoam
left a comment
There was a problem hiding this comment.
In general looks good. A small comment on docstring.
However, I did not understand the following action item in the PR description:
Release notification should maybe include a statemant, that Dice a second positional argument.
Co-authored-by: Noam Meltzer <tsnoam@gmail.com>
Pure API changes
Bot.send_poll:explanation,explanation_parse_mode,Poll.{explanation, explanation_entities, open_period, close_date}Bot.send_dice:emoji(for whatever reason, sending a 'darts' is considered a die now …Dice.emojiConvenience stuff
Poll.parse_explanation_entity/iesFilters.dice.diceandFilters.dice.dartsfor filtering only the corresponding emojis. Allow theFilters.dice.*([1, 2])syntax for bothTodo
Dicea second positional argument.telegram.error.BadRequest: Type of file mismatch. Need to investigate