Add Basketball Dice#1955
Add Basketball Dice#1955Poolitzer merged 10 commits intopython-telegram-bot:4.9_updatefrom spontanurlaub:basketball
Conversation
Added Basketball Dice Variation
There was a problem hiding this comment.
Thanks for the quick PR! Unfortunately, there is no API release yet that officially confirms that the API handles the new basketball (though it does). We could still add the new functionality with corresponding notes that basketball is currently undocumented. In any case, we'd need:
Bot.send_dice: update docs foremoji- Create
Filters.dice.basketballand updatetest_filters_dice_typeintest_filters.py. Please see the contribution guide on how to run the tests.
Could you do that?
Co-authored-by: Bibo-Joshi <hinrich.mahler@freenet.de>
|
The requested changes are implemented now. |
|
Thanks for the update. Still, after internal discussion we decided not to merge, before we get an official announcement from Telegram (that might i.e. even have info about the missing 6 for basketball). |
|
@Bibo-Joshi In general, we prefer not to merge undocumented features because they're prone to change. |
|
Thanks for that, I will merge it in my 4.9 branch. Do you want to be included in the author file as well? |
There is a new Dice Variation for the Basketball (🏀) emote, that only returns values from 1-5.