Merged
Conversation
Added Basketball Dice Variation
Co-authored-by: Bibo-Joshi <hinrich.mahler@freenet.de>
Add Basketball Dice
Member
|
Thanks for the quick PR! Will have a closer look later today/on the weekend
We're currently only testing
Can you test, if TG servers infere that automatically? If yes: I don't really see a need for someone setting that manually and hence, for adding the corresponding constants |
Member
Author
|
@Bibo-Joshi The docs say telegrams server automatically assume JPEG. I can test it if you want |
Bibo-Joshi
requested changes
Jun 5, 2020
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Hey, had a closer look.
- Docs need checking, as mentioned offline
test_messageshould be updated regardingto/from_dict/json- Depending on your tests, constants for
thumb_mime_typewould be good imo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basketball was added by @code1mountain, rest done by me.
Open questions: