Do not override builtin method help()#1997
Merged
Bibo-Joshi merged 2 commits intopython-telegram-bot:masterfrom Jun 16, 2020
Merged
Do not override builtin method help()#1997Bibo-Joshi merged 2 commits intopython-telegram-bot:masterfrom
Bibo-Joshi merged 2 commits intopython-telegram-bot:masterfrom
Conversation
Member
|
Personally, I don't see a need to change |
Contributor
Author
|
The only other examples that used help() are inllinebot and inlinekeyboard. Both updated now. |
Member
|
Thanks for you contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The echobot2 example overrides builtin method
help(). This PR renames thehelp(update, context)function tohelp_command(update, context).Perhaps change
starttostart_commandtoo?