Hey Jason, thanks for the pull request. I'll be testing/reviewing your code.
You mentioned about the Chinese firewall issue, how about a proxy feature? Would that help? If so, would you file a bug so we could start discussing more about it?

Would you mind to push ignoring .idea folder though? Thanks!

Actually i am going to buy a VPN latter. I noticed that there is a new version of your code, i will work on the new version then, just ignore the pull request this time 0 -0. I'm sorry for the .idea, i will pay attention on that next time.

No worries at all.
The way you simplified the code looks great! I made some comments and considerations. How about a is_inputfile function on InputFile to make the if even cleaner?

data['photo', 'video', ...] could be either:

• a file instance, like open('telegram.png', 'rb') or
• a str, like 'http://telegram.org/telegram.png (InputFile takes care to download and stream the content), as I'm writing this the HEAD tests if 'http' in data['video'], but I'm sure there are better ways to validate an URL.

if none of the options above, it falls on urlencode(data) simple post request.

Thanks!

I found the discussion related on discussion site. I think we may use urlparse in our case, even url.startwith('http') is OK for the flexible url rules. There seems to be little invalid url. How do you think about that?

Uhm, after reading the post you sent, startswith seems to be enough for
now, we can handle URL errors when fetching content then.
Em 11/07/2015 2:31 AM, "CM" notifications@github.com escreveu:

I found the discussion related on discussion site
http://stackoverflow.com/questions/827557/how-do-you-validate-a-url-with-a-regular-expression-in-python.
I think we may use urlparse in our case, even url.startwith('http') is OK
for the flexible url rules. There seems to be little invalid url. How do
you think about that?

—
Reply to this email directly or view it on GitHub
#2 (comment)
.