Refactor handling of message vs update filters#2032
Merged
Bibo-Joshi merged 2 commits intov13from Jul 28, 2020
Merged
Conversation
jsmnbom
requested changes
Jul 27, 2020
Member
jsmnbom
left a comment
There was a problem hiding this comment.
I'm very tired, but found a couple of thing that might need changes. Mostly just looks good tho!
jsmnbom
approved these changes
Jul 27, 2020
This was referenced Jul 30, 2020
Bibo-Joshi
added a commit
that referenced
this pull request
Aug 13, 2020
* Refactor handling of message vs update filters * address review
Bibo-Joshi
added a commit
that referenced
this pull request
Aug 16, 2020
* Refactor handling of message vs update filters * address review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned offline:
update_filteris a bit unsatisfactory to me. E.g. it leads to irritation with users (see #1595) and makes typing hard (see #1920)What this PR does is:
BaseFilter.__call__an abstract method and implement two subclasses:MessageFilterandUpdateFilter, each of which will take care of passing the right object tofilter()update_filter, make the filters inherit from those.BaseFiltertoMessage/UpdateFilterin order to make typing even more clear. This makes it breaking, butBaseFiltertoMessageHandleris not too bad. Leavingupdate_filter = Truewon't even hurt …Offline I also mentioned dropping
data_filter, but that was nonsense, as we need that for the short circuit logic of the filtersCloses #1595 and #1596