pollbot.py example was sending the poll to the effective_user and not…#2047
Merged
Bibo-Joshi merged 2 commits intopython-telegram-bot:masterfrom Aug 13, 2020
Merged
Conversation
… effective_chat... well, it's a poll to be answered by multiple uses.
Member
|
Well the answers are only received on a user basis, not chat one, so the "answer" will be send in a private chat anyway. I dont really see a big gain of your PR but I dont mind it either |
Contributor
Author
|
I think the pollbot example was meant to have some answers in the same poll_id... If you send the poll to a private chat(user) it will never receive more than one answer. |
Member
|
No yeah I guess you are right, never thought about running it in a group, but that change is OK. |
Member
|
pytest fails obviously unrelated and we can ignore the examples warning, as there is nothing new in the example. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's about pollbot.py example. The poll command was sending the poll to the update.effective_user.id... I think it should be update.effective_chat.id so multiple chat members could answer the poll.