Improve and expand CallbackQuery shortcuts#2172
Conversation
Poolitzer
left a comment
There was a problem hiding this comment.
When inline message id is set and a user is calling delete(), the not really helping error AttributeError: 'NoneType' object has no attribute 'chat_id' is presented. Why not raise a custom one? At least put that in the docs.
And also, why delete_message()? With the message class, we just call it delete. I prefer that its way shorter (what a shortcut is all about imo)
I guess you're right. Just copied from the other shortcuts. Actually, if we're at it, we can replace If we document |
|
"anywhere else" can something like this happen, outside of this class? I would be fine not doing it, but I think overall custom errors would be an improvement. |
|
okay but you didnt change delete_message to delete, intentional? |
uh, yes. I didn't understand your comment as "rename CQ.delete_message to CQ.delete", but as "why are you using |
|
LGTM then |
closes #2171