Conversation
harshil21
reviewed
Nov 8, 2020
Bibo-Joshi
requested changes
Nov 8, 2020
Member
There was a problem hiding this comment.
Left some minor comments. Three more general ones:
- we need tests for
MessageID copy_messageshould be tested for defaults, i.e.parse_modeandallow_sending_without_reply(maybe see my #2192 for how I tested that)- If you're starting with shortcuts already, maybe it's a good idea to just do all of WP12 here
Member
Author
I mean thats hard to do rn because it isnt merged yet and I feel like cherry picking is over the top. Just wait for merging #2192? |
# Conflicts: # telegram/bot.py # telegram/callbackquery.py # tests/test_bot.py # tests/test_callbackquery.py
Bibo-Joshi
requested changes
Nov 18, 2020
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
thanks for the updates! IMO we should wait for #2192 so that we can add the tests here and don't forget … Still, I left you a little work for the meantime :)
Co-authored-by: Bibo-Joshi <hinrich.mahler@freenet.de>
Bibo-Joshi
requested changes
Nov 18, 2020
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
some last nitpicks left ;)
Co-authored-by: Bibo-Joshi <hinrich.mahler@freenet.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding copy message and poll question length constant