Add filename parameter to all media sending methods for consistency#2249
Merged
Bibo-Joshi merged 2 commits intomasterfrom Dec 16, 2020
Merged
Add filename parameter to all media sending methods for consistency#2249Bibo-Joshi merged 2 commits intomasterfrom
Bibo-Joshi merged 2 commits intomasterfrom
Conversation
Poolitzer
approved these changes
Dec 16, 2020
Member
Poolitzer
left a comment
There was a problem hiding this comment.
looks good to me. Job fail is weird though
Member
Author
|
Yeah, those timeout errors sometimes happen … merging. Thanks for the review :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2237
Hope I got everything
I tried to make the docstrings informative while not making promises about the outcome.