Merged
Conversation
Poolitzer
requested changes
Jan 7, 2021
Member
Poolitzer
left a comment
There was a problem hiding this comment.
I nitpicked wording, we should go for past tense in all points imo.
I will go over this later and submit a review for the document itself, maybe add more stuff I can think of.
Co-authored-by: Poolitzer <25934244+Poolitzer@users.noreply.github.com>
harshil21
reviewed
Jan 9, 2021
harshil21
reviewed
Jan 10, 2021
Co-authored-by: Poolitzer <25934244+Poolitzer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thought this would be a neat way to remind both ourself and the PR-authors of some stuff that's easily forgotten … Could be extended if needed. But maybe there's an even better place for this?