Conversation
Member
|
I would vote in favour of implementing this, but since this is a dev dependency kind of, we should get votes from other maintainers I guess? |
Poolitzer
approved these changes
Jan 10, 2021
Member
Poolitzer
left a comment
There was a problem hiding this comment.
alright, looks good, just one comment
# Conflicts: # telegram/utils/helpers.py
Poolitzer
approved these changes
Jan 10, 2021
Member
Author
|
I'm gonna go ahead and merge. If we dislike it at some point, we can kick it, but we don't have to bee too strict on dev dependencies I guess … |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stumbled accros that project it thought it's neat. TBH, I'm not 100% we should add it to the pre-commit as it's somewhat young (2017) and doesn't seem well recognized in terms of stars, forks and dependent packages (https://github.com/asottile/pyupgrade).
Then again, dependent packages don't list pre-commit iirc, and it's apparently rather actively maintained by the pre-commit author himself.
Also I didn't find an option to make it not change files in pre-commit (it fails, but automatically modifies the files).
Anyway, even if we don't add it, at least the changes it made seem valid :)