Merged
Conversation
Signed-off-by: starry69 <starry369126@outlook.com>
Bibo-Joshi
requested changes
Jan 15, 2021
Signed-off-by: starry69 <starry369126@outlook.com>
Bibo-Joshi
requested changes
Jan 16, 2021
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Mh, actually you're right about self.get_me() already setting self._bot, but imo it's still more readible to assign the return value anyway.
Some more notes:
- Please document that bot is now comparable (See e.g. here) probably just do it als
.. versionadded:: 13.2 Objects of this class …
- After a closer look the tests fail b/c some tests want to monkeypatch
bot.bot, which is no longer possible. Ig just making them patchbot._botinstead should be fine - Some other tests fail, b/c
Botis no longer hashable.Bot.__hash__should returnhash(self.bot), as that's what we're comparing with. see here - For what the equality tests should look like please see here
Signed-off-by: starry69 <starry369126@outlook.com>
Bibo-Joshi
reviewed
Jan 16, 2021
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the updates! Just two comments left :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2319