Conversation
Member
I can, I did, I can confirm it worked. |
Member
Author
|
On the last run, Codecov didn't show results for some reason, but the PR looks okay in the dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:
For people stumbling upon this: After releasing this PR in v13.4 we became aware that is was unintentioally breaking. See here for details.
When ready closes #2416
Already tested
certto TG) & with self-signed certificate (passingcertto TG)To be done:
cleanto Deprecation: v15 #2347This also
cleanargument in favor ofdrop_pending_updatesas a) that conforms with the TG nomenclature, b) that name is more speakingip_addressparameter ofset_webhooktostart_webhook(tbh I don't really understand what it's good for, do we need some special casing for that?)When ready:
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (I did that but leaving it as todo here so we double check the version number before merging)