Introducing Api 5.1 by Poolitzer · Pull Request #2424 · python-telegram-bot/python-telegram-bot

Poolitzer · 2021-03-09T15:11:24Z

When merged, this closes #2423.

Open questions:

Should two ChatInviteLinks be equal, when the invite link and creator are equal, or in some other scenario?

Checklist for PRs

Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)

If the PR contains API changes (otherwise, you can delete this passage)

New classes:
- Added self._id_attrs and corresponding documentation
- __init__ accepts **_kwargs
Added new / updated shortcuts:
- In Chat & User for all methods that accept chat/user_id
- ~~[ ] In Message for all methods that accept chat_id and message_id~~
- ~~[ ] For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id~~
- ~~[ ] In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id~~
If relevant:
- Added new constants at telegram.constants and shortcuts to them as class variables
- Added new handlers for new update types
- Added new filters for new message (sub)types
- Added or updated documentation for the changed class(es) and/or method(s)
- Updated the Bot API version number in all places in README.rst and README_RAW.rst, including the badge

Active docs build is at https://python-telegram-bot.readthedocs.io/en/api_5.1/

github-actions

Hey! Looks like you edited the (dev) requirements or the pre-commit hooks. I'm just a friendly reminder too keep the pre-commit hook versions in sync with the dev requirements and the additional dependencies for the hooks in sync with the requirements :)

github-actions

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

telegram/bot.py

telegram/chatinvitelink.py

telegram/bot.py

Co-authored-by: Bibo-Joshi <hinrich.mahler@freenet.de>

Signed-off-by: starry69 <starry369126@outlook.com>

…on-telegram-bot into api_5.1

Signed-off-by: starry69 <starry369126@outlook.com>

Bibo-Joshi · 2021-03-10T21:28:09Z

ChatMemberHandler is up for discussion. Adding two handlers MyChatMemberHandler and ChatMemberHandler seemed a bit extensive to me, so thought that this could be a feasible mid way.

Bibo-Joshi

@Poolitzer : We'll need new shortcuts for Chat.do_stuff_with_invite_links

@starry69 we'll need filters for the new message types

telegram/bot.py

telegram/chatinvitelink.py

telegram/message.py

telegram/voicechat.py

Signed-off-by: starry69 <starry369126@outlook.com>

…on-telegram-bot into api_5.1

Signed-off-by: starry69 <starry369126@outlook.com>

starry-shivam · 2021-03-11T03:22:33Z

@Poolitzer : We'll need new shortcuts for Chat.do_stuff_with_invite_links

@starry69 we'll need filters for the new message types

Yea gonna do in evening

harshil21

did another general review

telegram/ext/chatmemberhandler.py

telegram/voicechat.py

docs/source/telegram.ext.chatmemberhandler.rst

docs/source/telegram.chatmemberupdated.rst

telegram/base.py

telegram/chatinvitelink.py

telegram/bot.py

telegram/chatinvitelink.py

telegram/voicechat.py

Signed-off-by: starry69 <starry369126@outlook.com>

change place of version adding, added obj:True as doc string, changing how member limit is initiated

telegram/bot.py

tests/test_chatinvitelink.py

tests/test_filters.py

tests/test_voicechat.py

github-actions

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

* add bot api version in constants Signed-off-by: starry69 <starry369126@outlook.com> * addressing review Signed-off-by: starry69 <starry369126@outlook.com> * add versioning directive Co-authored-by: Bibo-Joshi <hinrich.mahler@freenet.de>

github-actions

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

github-actions

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

CustomIcon · 2021-03-14T18:22:05Z

edits README
github-actions bot: 🔫

Poolitzer closed this Mar 9, 2021

Poolitzer reopened this Mar 9, 2021

Bibo-Joshi added the ⚙️ bot-api affected functionality: bot-api label Mar 9, 2021

github-actions bot reviewed Mar 9, 2021

View reviewed changes

python-telegram-bot deleted a comment from Poolitzer Mar 9, 2021

Feat: New invite links

09ecc8b

Poolitzer force-pushed the api_5.1 branch from fb87a34 to 09ecc8b Compare March 9, 2021 15:15

Bibo-Joshi reviewed Mar 9, 2021

View reviewed changes

telegram/bot.py Outdated Show resolved Hide resolved

telegram/chatinvitelink.py Outdated Show resolved Hide resolved

Poolitzer commented Mar 9, 2021

View reviewed changes

telegram/bot.py Outdated Show resolved Hide resolved

Poolitzer and others added 12 commits March 9, 2021 17:21

Fix: doc strings

fe3df4f

Co-authored-by: Bibo-Joshi <hinrich.mahler@freenet.de>

new dice, new admin privilege, revoke_messages, update and fix some docs

22b71bb

Merge remote-tracking branch 'origin/api_5.1' into api_5.1

d378acd

add missing param to shortcut

69333db

Merge branch 'master' into api_5.1

4b26419

Add ChatMemberUpdated

a6228a7

Add voicechat related objects

0ef5113

Signed-off-by: starry69 <starry369126@outlook.com>

Merge branch 'api_5.1' of https://github.com/python-telegram-bot/pyth…

fdb4646

…on-telegram-bot into api_5.1

add versionadd tags

101abc6

Signed-off-by: starry69 <starry369126@outlook.com>

Fix filter tests

7e868d4

Update tg.Update

d7400ef

ChatMemberHandler

5737532

Add versioning directives

e88a08e

Bibo-Joshi requested changes Mar 10, 2021

View reviewed changes

starry-shivam added 3 commits March 11, 2021 08:35

add can_manage_voice_chats attr and fix docs

4e2a437

Signed-off-by: starry69 <starry369126@outlook.com>

Merge branch 'api_5.1' of https://github.com/python-telegram-bot/pyth…

2beb5fa

…on-telegram-bot into api_5.1

fix chat shortcut

b7eac48

Signed-off-by: starry69 <starry369126@outlook.com>

harshil21 reviewed Mar 11, 2021

View reviewed changes

Bibo-Joshi added 3 commits March 11, 2021 17:57

address review

8c684a2

MADTC

164e0a5

Chat.message_auto_delete_time

0d3110c

Bibo-Joshi requested changes Mar 11, 2021

View reviewed changes

telegram/bot.py Show resolved Hide resolved

telegram/chatinvitelink.py Outdated Show resolved Hide resolved

telegram/voicechat.py Show resolved Hide resolved

telegram/voicechat.py Outdated Show resolved Hide resolved

Some doc fixes

9d45d12

Bibo-Joshi added this to the v13.4 milestone Mar 11, 2021

starry-shivam and others added 6 commits March 12, 2021 17:25

address review

52b1b95

Signed-off-by: starry69 <starry369126@outlook.com>

welp

5ee1482

Signed-off-by: starry69 <starry369126@outlook.com>

Add voicechat related filters

c973563

Signed-off-by: starry69 <starry369126@outlook.com>

Fix: Addressing review

edb6d28

change place of version adding, added obj:True as doc string, changing how member limit is initiated

feat: adding chat shortcuts for invite links

5fbc92c

fix: changing equality of chatinviteobjects

c89af2a

Bibo-Joshi requested changes Mar 13, 2021

View reviewed changes

Bibo-Joshi added 6 commits March 13, 2021 16:22

Merge branch 'master' into api_5.1

d63500a

Non-test comments

18da765

Some test fixes

15ca15a

A bit more tests

ae76abe

Bump API version in both readmes

3635f95

Increase coverage

a291c0f

github-actions bot reviewed Mar 13, 2021

View reviewed changes

github-actions bot reviewed Mar 14, 2021

View reviewed changes

pre-commit & coverage

a31082c

github-actions bot reviewed Mar 14, 2021

View reviewed changes

Bibo-Joshi merged commit ac02bce into master Mar 14, 2021

Bibo-Joshi deleted the api_5.1 branch March 14, 2021 15:41

Bibo-Joshi mentioned this pull request Mar 14, 2021

Fix setup.py #2431

Merged

python-telegram-bot locked as resolved and limited conversation to collaborators Mar 14, 2021

Conversation

Poolitzer commented Mar 9, 2021 • edited by Bibo-Joshi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist for PRs

If the PR contains API changes (otherwise, you can delete this passage)

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Bibo-Joshi commented Mar 10, 2021

Uh oh!

Bibo-Joshi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

starry-shivam commented Mar 11, 2021

Uh oh!

harshil21 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

CustomIcon commented Mar 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Poolitzer commented Mar 9, 2021 •

edited by Bibo-Joshi

Loading

Bibo-Joshi left a comment •

edited

Loading