Skip to content

Fix & improve some examples#2441

Merged
Bibo-Joshi merged 6 commits intomasterfrom
examples-fixes
Mar 28, 2021
Merged

Fix & improve some examples#2441
Bibo-Joshi merged 6 commits intomasterfrom
examples-fixes

Conversation

@harshil21
Copy link
Member

@harshil21 harshil21 commented Mar 23, 2021 •
edited
Loading

@harshil21 harshil21 added bug 🐛 ⚙️ examples affected functionality: examples labels Mar 23, 2021
github-actions[bot]
github-actions bot reviewed Mar 23, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

@Poolitzer Telegram GithubBot Revised
Copy link
Member

Poolitzer commented Mar 23, 2021

@harshil21 since you are changing examples anyway, can you throw in a ForceReply somewhere? I think an example of that is good for people

@harshil21 harshil21 changed the title Fix some examples Fix & improve some examples Mar 23, 2021
@harshil21 harshil21 added this to the v13.5 milestone Mar 24, 2021
Bibo-Joshi
Bibo-Joshi requested changes Mar 26, 2021
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements! Left a comment. Also you mentioned:

  • Handle empty inline queries without raising errors.

but I don't see that? If you want to add that, maybe an idea would be to use switch_pm_text to display a help message similarly to what rulesbot does. That feature is also little known.

@harshil21
Copy link
Member Author

harshil21 commented Mar 27, 2021

but I don't see that?

Oops, I guess I discarded those changes by mistake. It was if query == ""; return. The exception raised when it's empty is
Can't parse inline query result: input message content is not specified.

maybe an idea would be to use switch_pm_text to display a help message similarly to what rulesbot does.

So should I also put in switch_pm_{text, parameter}, along with the fix above?

@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Mar 27, 2021

but I don't see that?

Oops, I guess I discarded those changes by mistake. It was if query == ""; return. The exception raised when it's empty is
Can't parse inline query result: input message content is not specified.

Jup, makes sense :)

maybe an idea would be to use switch_pm_text to display a help message similarly to what rulesbot does.

So should I also put in switch_pm_{text, parameter}, along with the fix above?

If you like to. Not important, just an idea ;)

@Bibo-Joshi Bibo-Joshi merged commit 43f5aea into master Mar 28, 2021
@Bibo-Joshi Bibo-Joshi deleted the examples-fixes branch March 28, 2021 16:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2021
@Bibo-Joshi Bibo-Joshi added 🔌 bug pr description: bug and removed bug 🐛 labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Bibo-Joshi Bibo-Joshi Bibo-Joshi requested changes

Assignees

No one assigned

Labels

🔌 bug pr description: bug ⚙️ examples affected functionality: examples

Projects

None yet

Milestone

v13.5

Development

Successfully merging this pull request may close these issues.

[BUG] Broken button '4' in inlinekeyboard2.py example

3 participants

@harshil21 @Poolitzer @Bibo-Joshi